Convert all variant analysis commands to typed commands#2191
Merged
robertbrignull merged 9 commits intomainfrom Mar 22, 2023
Merged
Convert all variant analysis commands to typed commands#2191robertbrignull merged 9 commits intomainfrom
robertbrignull merged 9 commits intomainfrom
Conversation
3 tasks
d5c771b to
4a9708d
Compare
4a9708d to
1678732
Compare
1678732 to
0c9df6e
Compare
koesie10
approved these changes
Mar 21, 2023
Member
koesie10
left a comment
There was a problem hiding this comment.
LGTM, I just have 1 very minor suggestion
Comment on lines
+5
to
+10
| import { RepositoriesFilterSortStateWithIds } from "../pure/variant-analysis-filter-sort"; | ||
| import { | ||
| VariantAnalysis, | ||
| VariantAnalysisScannedRepository, | ||
| VariantAnalysisScannedRepositoryResult, | ||
| } from "../variant-analysis/shared/variant-analysis"; |
Member
There was a problem hiding this comment.
Can we make these type imports like all of the above imports just so we can see at once that there are no runtime circular dependencies?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check each individual commit because I've done one commit per command.
This did actually find some places where our command arguments were incorrect. For the
codeQL.monitorVariantAnalysisandcodeQL.autoDownloadVariantAnalysisResultcommands we were accepting a cancellation token parameter, but this parameter was not being passed in practice when we were invoking the commands. This meant the type of the argument was incorrect, but the commands already accounted this by checking if the token was undefined and ignoring it if so. Therefore this should be a behaviour-preserving change because the cancellation token was in fact always undefined already.For
codeQL.loadVariantAnalysisRepoResultsI chose to give it a return type because this means we can use the existingloadResultsmethod without having to define a new method that just ignores the return value. But I could do this if you think it would be better.Checklist
ready-for-doc-reviewlabel there.