Convert local query commands to typed commands#2194
Merged
Conversation
The local query commands are using a separate logger, and this is not supported by the command manager because it is quite specific to this extension. Therefore, we create a separate command manager which uses a different logger to separate the commands.
elenatanasoiu
approved these changes
Mar 22, 2023
| databaseManager: dbm, | ||
| queryRunner, | ||
| queryHistoryManager, | ||
| databaseManager, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review this commit-by-commit. Each commit makes the move to typed commands a bit easier.
One difference from all other typed commands is that the local query commands are using a separate logger, and this is not supported by the command manager because it is quite specific to this extension. Therefore, we create a separate command manager which uses a different logger to separate the commands. I have purposefully not added this to the
Appinterface since we're not using it anywhere yet. Instead of adding it to theExtensionApp, we could also create it in theextension.tsfile and not store it on theExtensionApp. I'm not sure which approach is better.Checklist
ready-for-doc-reviewlabel there.