Move remaining local database commands to databases UI#2195
Merged
Conversation
Some of the methods in the `DatabaseUI` were public because they were used in the `extension.ts` file. We have moved these method calls into this file, so they do not need to be public anymore. We can also get rid of the separation between some of these methods, so I've moved them into the function that calls them.
elenatanasoiu
approved these changes
Mar 22, 2023
| } | ||
|
|
||
| public async chooseDatabaseArchive( | ||
| private async chooseDatabaseArchive( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review this commit-by-commit. This moves any of the commands which were calling into the local databases UI to be within the local databases UI. This simplifies the code and reduces the number of commands being registered in
extension.ts.Checklist
ready-for-doc-reviewlabel there.