Convert AST and CFG commands to typed commands#2196
Merged
Conversation
robertbrignull
approved these changes
Mar 22, 2023
| ...variantAnalysisManager.getCommands(), | ||
| ...databaseUI.getCommands(), | ||
| ...dbModule.getCommands(), | ||
| ...getAstCfgCommands({ |
Contributor
There was a problem hiding this comment.
Hmm, this is a lot of arguments and it obscures things a bit. I think it's fine for this PR and I'm not suggesting anything right now, but it would be nice if we could make this clearer and clearer in the future.
Member
Author
There was a problem hiding this comment.
I completely agree. In the future we should probably create separate modules and then we'd be able to just pass any dependent modules to it, and create the AST viewer and template providers in the module itself. However, this is something for the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review this commit-by-commit. This converts the AST and CFG commands to typed commands. It also moves them to a separate file to reduce the size of
extension.ts.Checklist
ready-for-doc-reviewlabel there.