Skip to content

Add codeQL.checkForUpdatesToCLI type for command#2213

Merged
koesie10 merged 1 commit intomainfrom
koesie10/check-for-updates-typed-command
Mar 23, 2023
Merged

Add codeQL.checkForUpdatesToCLI type for command#2213
koesie10 merged 1 commit intomainfrom
koesie10/check-for-updates-typed-command

Conversation

@koesie10
Copy link
Copy Markdown
Member

The codeQL.checkForUpdatesToCLI command is registered pre-activation, and we don't really want to create the command manager before activation, so this will just add the correct type without registering it using the command manager.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

The `codeQL.checkForUpdatesToCLI` command is registered pre-activation,
and we don't really want to create the command manager before
activation, so this will just add the correct type without registering
it using the command manager.
@koesie10 koesie10 marked this pull request as ready for review March 23, 2023 09:10
@koesie10 koesie10 requested a review from a team as a code owner March 23, 2023 09:10
@koesie10 koesie10 requested a review from a team March 23, 2023 09:10
@koesie10 koesie10 merged commit dae472c into main Mar 23, 2023
@koesie10 koesie10 deleted the koesie10/check-for-updates-typed-command branch March 23, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants