Skip to content

Remove commandRunnerWithProgress#2214

Merged
koesie10 merged 1 commit intomainfrom
koesie10/remove-command-runner-with-progress
Mar 23, 2023
Merged

Remove commandRunnerWithProgress#2214
koesie10 merged 1 commit intomainfrom
koesie10/remove-command-runner-with-progress

Conversation

@koesie10
Copy link
Copy Markdown
Member

The commandRunnerWithProgress is unused because all commands have been converted to using commandRunner in combination with withProgress.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

The `commandRunnerWithProgress` is unused because all commands have been
converted to using `commandRunner` in combination with `withProgress`.
@koesie10 koesie10 requested a review from a team March 23, 2023 10:10
@koesie10 koesie10 requested a review from a team as a code owner March 23, 2023 10:10
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@koesie10 koesie10 enabled auto-merge March 23, 2023 10:14
@koesie10 koesie10 merged commit 73b0a05 into main Mar 23, 2023
@koesie10 koesie10 deleted the koesie10/remove-command-runner-with-progress branch March 23, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants