Convert call sites to use typed commands (part 1)#2217
Merged
robertbrignull merged 9 commits intomainfrom Mar 23, 2023
Merged
Conversation
Contributor
Author
|
Ugh, lots of test compilation errors. Somehow I never spot these locally. 😞 |
…nt.ts to call typed commands
10e9eb7 to
14dc391
Compare
Contributor
Author
|
Test should all be fixed now. Things compile for me locally. I've rebased the changes into the original commits, so you can see which changes necessitated which other changes. |
koesie10
approved these changes
Mar 23, 2023
| // Builtin commands where the implementation is provided by VS Code and not by this extension. | ||
| // See https://code.visualstudio.com/api/references/commands | ||
| export type BuiltInVsCodeCommands = { | ||
| "codeQLDatabases.focus": () => Promise<void>; |
Member
There was a problem hiding this comment.
Perhaps add a comment for this command? It's not entirely obvious if you're just looking at the file that this is a command added by VS Code on custom views.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts some places that call commands to use typed commands. This isn't everything but I'll try to open a few smaller PRs instead of one giant PR. That way it'll be easier to review and easier to adapt thoughts and ideas before getting too deep into things.
Each commit converts a single file, so if you want to review commit-by-commit then that is an option.
This PR involves:
ApporAppCommandManagerto wherever it is needed.VariantAnalaysisManagerthen give it the fullApp, but when it's a standalone function that triggers commands but doesn't do anything else then give it just theAppCommandManager.Checklist
ready-for-doc-reviewlabel there.