Skip to content

Remove remaining references to commandRunner #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koesie10 merged 1 commit into from
Mar 23, 2023
Merged

Remove remaining references to commandRunner #2219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/common/vscode/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
import { telemetryListener } from "../../telemetry";

/**
* Create a command manager for VSCode, wrapping the commandRunner
* Create a command manager for VSCode, wrapping registerCommandWithErrorHandling
* and vscode.executeCommand.
*/
export function createVSCodeCommandManager<
Expand Down
7 changes: 4 additions & 3 deletions extensions/ql-vscode/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ function registerErrorStubs(

stubbedCommands.forEach((command) => {
if (excludedCommands.indexOf(command) === -1) {
// This is purposefully using `commandRunner` instead of the command manager because these
// This is purposefully using `registerCommandWithErrorHandling` instead of the command manager because these
// commands are untyped and registered pre-activation.
errorStubs.push(
registerCommandWithErrorHandling(command, stubGenerator(command)),
Expand Down Expand Up @@ -341,7 +341,7 @@ export async function activate(
),
);
ctx.subscriptions.push(
// This is purposefully using `commandRunner` directly instead of the command manager
// This is purposefully using `registerCommandWithErrorHandling` directly instead of the command manager
// because this command is registered pre-activation.
registerCommandWithErrorHandling(checkForUpdatesCommand, () =>
installOrUpdateThenTryActivate(
Expand Down Expand Up @@ -1035,7 +1035,8 @@ function addUnhandledRejectionListener() {
// "uncaughtException" will trigger whenever an exception reaches the top level.
// This covers extension initialization and any code within a `setTimeout`.
// Notably this does not include exceptions thrown when executing commands,
// because `commandRunner` wraps the command body and handles errors.
// because `registerCommandWithErrorHandling` wraps the command body and
// handles errors.
process.addListener("uncaughtException", handler);

// "unhandledRejection" will trigger whenever any promise is rejected and it is
Expand Down