Merged
Conversation
Contributor
Author
|
Proof that retries are still working in CI: https://github.com/github/vscode-codeql/actions/runs/4501772829/jobs/7922660510?pr=2227#step:6:125
|
koesie10
reviewed
Mar 23, 2023
Comment on lines
+111
to
+112
| env: | ||
| CI: true |
Member
There was a problem hiding this comment.
The CI definitions should be unnecessary, the CI environment variable is set by default in GitHub Actions (and most other CI system).
elenatanasoiu
force-pushed
the
elena/disable-local-retry
branch
from
bcd1eae to
fceaa4e
Compare
We introduced this change to help with reducing flakiness in CI [1]. This has a slightly different effect locally, where every failed test will output three times. This in turn makes it harder to read, especially when you have multiple failing tests. Since the original intent for this behaviour was to be used in CI, I'm proposing we disable it when the CI env variable isn't set. I've opted to set it for all jobs involving tests, just for consistency. I'm happy to limit it to just the places where it's required. [1]: #2059
elenatanasoiu
force-pushed
the
elena/disable-local-retry
branch
from
fceaa4e to
c882a9f
Compare
koesie10
approved these changes
Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We introduced this change to help with reducing flakiness in CI.
This has a slightly different effect locally, where every failed test will output three times.
This in turn makes it harder to read, especially when you have multiple failing tests.
Since the original intent for this behaviour was to be used in CI, I'm proposing we disable it when the CI env variable isn't set.
I've opted to set it for all jobs involving tests, just for consistency. I'm happy to limit it to just the places where it's required.