Rename query history read and write methods#2231
Merged
norascheuch merged 2 commits intomainfrom Mar 24, 2023
Merged
Conversation
3 tasks
koesie10
approved these changes
Mar 24, 2023
Member
koesie10
left a comment
koesie10
left a comment
There was a problem hiding this comment.
LGTM, just a naming suggestion
| import { redactableError } from "../../pure/errors"; | ||
|
|
||
| export async function deserializeQueryHistory( | ||
| export async function readFromQueryHistoryFile( |
Member
There was a problem hiding this comment.
Should we keep the naming between these two names consistent by naming it readQueryHistoryFromFile?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of an endeavour to separate data and domain model for the query history. We are just renaming the methods responsible for reading and writing query history data to disk here.
Checklist
ready-for-doc-reviewlabel there.