Convert call sites to use typed commands (part 6): createVSCodeCommandManager in tests

[robertbrignull]

We have quite a few tests that trigger commands as part of them. They do this to call code that isn't accessible otherwise. The easiest way to convert these tests to use typed commands is to use createVSCodeCommandManager to get a real command manager than will trigger real commands. By doing this the the behaviour should be exactly the same except that the commands are type checked.

It would likely be better overall if these tests were able to call code without using commands. That would likely lead to better organised code. However, that is more of a long term goal.

Does this make sense? Or should we put in more effort to refactor the tests? Or something else entirely?

Checklist

• CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
• Issues have been created for any UI or other user-facing changes made by this pull request.
• [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

[koesie10]

This approach makes sense to me, I don't think we should refactor all tests to call directly into the methods right now.