Open correct tutorial workspace on Windows#2240
Merged
shati-patel merged 3 commits intomainfrom Mar 28, 2023
Merged
Conversation
Follow-up to #2188 (review), which didn't quite work on Windows due to URI parsing issues. Using `Uri.file` instead of `Uri.parse` works on Windows and I'll test in a codespace to make sure it also works there!
adityasharad
approved these changes
Mar 27, 2023
Contributor
adityasharad
left a comment
adityasharad
left a comment
There was a problem hiding this comment.
Looks right. You can make sure this keeps working in future via integration tests that check out the template repo, which I think you have planned already.
Contributor
Author
|
Still attempting to get the tests to pass (looks like the drive letter on Windows is being normalized to lowercase) 🙃 |
Co-authored-by: Elena Tanasoiu <elenatanasoiu@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2188 (review), which didn't quite work on Windows due to URI parsing issues.
Using
Uri.fileinstead ofUri.parseworks on Windows and I'll test in a codespace to make sure it also works there! (update: it works)Checklist
N/A
ready-for-doc-reviewlabel there.