Skip to content

Upgrade to Storybook 7#2259

Merged
koesie10 merged 2 commits intomainfrom
koesie10/upgrade-storybook-7
Jul 19, 2023
Merged

Upgrade to Storybook 7#2259
koesie10 merged 2 commits intomainfrom
koesie10/upgrade-storybook-7

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Apr 3, 2023

This upgrades to Storybook 7. It is based on the automigration with manual changes for the add-on. There should be no changes in actual behavior between Storybook 6 and 7.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10
Copy link
Copy Markdown
Member Author

koesie10 commented Jun 8, 2023

The problem seems to be the glob package. Storybook depends on glob-promise, which has a peer dependency of glob version 8. We are installing version 9, which is a full rewrite. Therefore, glob-promise doesn't work.

This should be resolved in the next version of Storybook: storybookjs/storybook@ac16a38. See https://redirect.github.com/ahmadnassri/node-glob-promise/issues/204

@koesie10 koesie10 force-pushed the koesie10/upgrade-storybook-7 branch 4 times, most recently from 7239ec0 to b8591d4 Compare June 9, 2023 10:47
@koesie10 koesie10 force-pushed the koesie10/upgrade-storybook-7 branch from e7c610e to b830781 Compare July 18, 2023 13:30
@koesie10
Copy link
Copy Markdown
Member Author

This is now ready for review since Storybook 7.1 has just been released. There should be no changes in behavior between Storybook 6 and Storybook 7.

@koesie10 koesie10 marked this pull request as ready for review July 18, 2023 13:56
@koesie10 koesie10 requested review from a team as code owners July 18, 2023 13:56
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works for me locally

@koesie10 koesie10 merged commit a90b85c into main Jul 19, 2023
@koesie10 koesie10 deleted the koesie10/upgrade-storybook-7 branch July 19, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants