Show external API calls in data extensions editor#2263
Merged
Conversation
This updates the view of the data extensions editor to show a table of possible sources/sinks/flow summaries that can be edited. It's not yet possible to save the changes or load the existing file.
This was referenced Apr 4, 2023
charisk
reviewed
Apr 4, 2023
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
Generally looking good. I have some comments mainly around code readability but since we're aiming to just get a prototype out a lot of it can be left for later on.
|
|
||
| await this.showProgress({ | ||
| message: "Finalizing results", | ||
| step: 1450, |
Member
Author
There was a problem hiding this comment.
These numbers are based on what makes it look "nice" in the view. They are out of 1500 since that allows some granularity.
3 tasks
charisk
approved these changes
Apr 5, 2023
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback, looking good!
|
|
||
| await this.showProgress({ | ||
| message: "Decoding results", | ||
| step: 1200, |
Contributor
There was a problem hiding this comment.
I think it's worth a comment explaining these numbers as they seem quite arbitrary.
Member
Author
There was a problem hiding this comment.
I've added a comment on the showProgress method explaining how this got to be a max step of 1500.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the view of the data extensions editor to show a table of possible sources/sinks/flow summaries that can be edited. It's not yet possible to save the changes or load the existing file.
This is quite a big PR because it runs the query and shows the results. However, I don't think splitting this up further would really make this clearer. However, the extension and view parts can be reviewed relatively independently since the only communication between them is through two messages.
Checklist
ready-for-doc-reviewlabel there.