Skip to content

Upgrade ts-jest#2269

Merged
koesie10 merged 2 commits intomainfrom
koesie10/upgrade-ts-jest
Apr 6, 2023
Merged

Upgrade ts-jest#2269
koesie10 merged 2 commits intomainfrom
koesie10/upgrade-ts-jest

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Apr 5, 2023

The version of ts-jest we were using was given a warning that it did not support TypeScript 5, even though it was working fine. The latest version of ts-jest adds official support for TypeScript and removes the warning.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

The version of ts-jest we were using was given a warning that it did
not support TypeScript 5, even though it was working fine. The latest
version of ts-jest adds official support for TypeScript and removes the
warning.
@koesie10 koesie10 added dependencies Pull requests that update a dependency file secexp labels Apr 5, 2023
@koesie10 koesie10 requested a review from a team as a code owner April 5, 2023 09:50
@koesie10 koesie10 requested a review from a team April 5, 2023 09:51
@charisk
Copy link
Copy Markdown
Contributor

charisk commented Apr 6, 2023

We seem to be missing the package.json change.

@koesie10
Copy link
Copy Markdown
Member Author

koesie10 commented Apr 6, 2023

We seem to be missing the package.json change.

There's no need to change the package.json in this case since we're only updating a minor/patch version. This is basically just running npm upgrade ts-jest so we get the latest version.

@charisk
Copy link
Copy Markdown
Contributor

charisk commented Apr 6, 2023

We seem to be missing the package.json change.

There's no need to change the package.json in this case since we're only updating a minor/patch version. This is basically just running npm upgrade ts-jest so we get the latest version.

Ah cool.

@koesie10 koesie10 enabled auto-merge April 6, 2023 07:40
@koesie10 koesie10 merged commit 7470e72 into main Apr 6, 2023
@koesie10 koesie10 deleted the koesie10/upgrade-ts-jest branch April 6, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file secexp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants