Skip to content

Split up codeQL.restartQueryServer command#2273

Merged
robertbrignull merged 1 commit intomainfrom
robertbrignull/splitCommand/codeQL.restartQueryServer
Apr 5, 2023
Merged

Split up codeQL.restartQueryServer command#2273
robertbrignull merged 1 commit intomainfrom
robertbrignull/splitCommand/codeQL.restartQueryServer

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

Splits up the codeQL.restartQueryServer command into three commands, so we avoid calling each one from more than one code or user-triggered location. This will allow us to differentiate command usages in our telemetry.

The original codeQL.restartQueryServer command is defined in package.json and is available in the command palette. I believe we don't need to add either of the two new versions there, because we don't want them to be accessible to the user.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team April 5, 2023 12:45
@robertbrignull robertbrignull enabled auto-merge April 5, 2023 13:12
@robertbrignull robertbrignull merged commit e84d488 into main Apr 5, 2023
@robertbrignull robertbrignull deleted the robertbrignull/splitCommand/codeQL.restartQueryServer branch April 5, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants