Fix error when closing MRVA webview during extension activation#2280
Merged
Fix error when closing MRVA webview during extension activation#2280
Conversation
This fixes the "Webview is disposed" error which occurs when the user closes the variant analysis webview while the extension is still activating. We will now check whether the webview is disposed before restoring the view.
Contributor
|
The deserialization stuff are becoming more and more complex. Do we really need that functionality or is there an opportunity here to simplify our code a bit? |
charisk
approved these changes
Apr 6, 2023
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
Since the feature is there atm I'll leave it for another time to discuss its future.
The code LGTM (I've not tested locally).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the "Webview is disposed" error which occurs when the user closes the variant analysis webview while the extension is still activating. We will now check whether the webview is disposed before restoring the view.
Checklist
ready-for-doc-reviewlabel there.