Allow creating new model file in existing data extension#2296
Merged
Conversation
This will allow a user to create a new model file in an existing data extension when opening the data extension editor. There is some validation on the name of the model file, which depends on reading in the qlpack.
`outputFile` will create the parent directory if it doesn't exist yet, so this will allow users to specify a sub-directory for the model file.
aeisenberg
reviewed
Apr 11, 2023
3 tasks
3 tasks
aeisenberg
approved these changes
Apr 13, 2023
|
|
||
| export async function pickExtensionPackModelFile( | ||
| cliServer: Pick<CodeQLCliServer, "resolveQlpacks" | "resolveExtensions">, | ||
| databaseItem: Pick<DatabaseItem, "name">, |
Contributor
There was a problem hiding this comment.
The extension file doesn't need to be in an extension pack. If the extension file is in the pack that contains the query to run (or any of its transitive dependencies), then the extension file will be loaded during evaluation.
This is a bit of a complicated concept for most users since the set of extension files used depends on which query is run. So, maybe this isn't necessary to implement for the PoC, but keep this in mind for the general release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow a user to create a new model file in an existing data extension when opening the data extension editor. There is some validation on the name of the model file, which depends on reading in the qlpack.
Screen.Recording.2023-04-11.at.17.00.18.mov
Based on #2295
Checklist
ready-for-doc-reviewlabel there.