Fix weird behavior of Quick Query in non-multi-root workspaces#230
Merged
jcreedcmu merged 1 commit intogithub:masterfrom Mar 17, 2020
Merged
Fix weird behavior of Quick Query in non-multi-root workspaces#230jcreedcmu merged 1 commit intogithub:masterfrom
jcreedcmu merged 1 commit intogithub:masterfrom
Conversation
aeisenberg
reviewed
Mar 9, 2020
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
LGTM. Though someone with more experience should approve.
aeisenberg
approved these changes
Mar 16, 2020
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Feel confident enough to approve this request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from a single-root workspace, Quick Query tries to add a workspace folder which points into workspace state, which then causes an extension host restart, and a different workspace state, leading to two Quick Query workspace folders.
The restart upon switching from single-root to multi-root appears to be unavoidable, and interrupts extension code execution, see microsoft/vscode#69335 (comment) for details.