Add steps to the pull request checklist to inform the documentation team#231
Merged
henrymercer merged 1 commit intomasterfrom Feb 12, 2020
Merged
Add steps to the pull request checklist to inform the documentation team#231henrymercer merged 1 commit intomasterfrom
henrymercer merged 1 commit intomasterfrom
Conversation
jcreedcmu
previously approved these changes
Feb 11, 2020
shati-patel
previously approved these changes
Feb 11, 2020
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Thank you! This is really helpful ✨
(Not sure what the preferred process is for merging in this repo, but this is ready to merge whenever you like!)
henrymercer
dismissed stale reviews from shati-patel and jcreedcmu
via
0b3fc98
henrymercer
force-pushed
the
pr-template-docs-cc
branch
from
c428783 to
0b3fc98
Compare
jcreedcmu
approved these changes
Feb 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add steps to the checklist in the PR template to ensure that appropriate process is followed so that the documentation team are kept up to date. The reviewer of each PR should ensure that these steps have been completed when reviewing the PR.
Checklist