Conversation
robertbrignull
approved these changes
Apr 13, 2023
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
All changes LGTM
The index.ts file is an approach I haven't seen us use before, but it makes sense to designate repo-states-store.ts as the canonical entry point to that whole directory.
Contributor
Author
FWIW we've been using it in a few places (e.g. https://github.com/github/vscode-codeql/blob/main/extensions/ql-vscode/src/common/index.ts). Probably something we should talk about standardising though (and making visible!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed names used in the repo states store, models (data/domain) and mappers, and updated them to match conventions agreed.
This PR looks fairly big but the changes are pretty small and straight forward. Please review commit by commit to see the differences.
Checklist
N/A:
ready-for-doc-reviewlabel there.