Skip to content

Add better support for different languages in data extension editor#2333

Merged
koesie10 merged 1 commit intomainfrom
koesie10/data-extension-editor-csharp
Apr 17, 2023
Merged

Add better support for different languages in data extension editor#2333
koesie10 merged 1 commit intomainfrom
koesie10/data-extension-editor-csharp

Conversation

@koesie10
Copy link
Copy Markdown
Member

There were still some places where we were hardcoding Java in the data extension editor. This changes these places to use the database item language instead.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

There were still some places where we were hardcoding Java in the data
extension editor. This changes these places to use the database item
language instead.
@koesie10 koesie10 requested a review from starcke April 17, 2023 12:27
@koesie10 koesie10 requested a review from a team as a code owner April 17, 2023 12:27
Copy link
Copy Markdown
Contributor

@starcke starcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I think I had already created at pack manually before your change to auto-create the packs got in. Thanks for fixing this.

@koesie10 koesie10 merged commit 3c0b3e4 into main Apr 17, 2023
@koesie10 koesie10 deleted the koesie10/data-extension-editor-csharp branch April 17, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants