Skip to content

Update library used by java query.#2338

Merged
starcke merged 2 commits intomainfrom
starcke/update-java-lib
Apr 18, 2023
Merged

Update library used by java query.#2338
starcke merged 2 commits intomainfrom
starcke/update-java-lib

Conversation

@starcke
Copy link
Copy Markdown
Contributor

@starcke starcke commented Apr 17, 2023

This updates java.ts to have a more recent version of the ExternalAPI.qll file, so that neutral predicates work.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@starcke starcke requested a review from koesie10 April 17, 2023 13:44
@starcke starcke requested a review from a team as a code owner April 17, 2023 13:44
Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be slightly easier to follow if we kept the indentation as-is since that will also ensure the correct indentation (i.e. no indentation) is added on-disk.

@starcke
Copy link
Copy Markdown
Contributor Author

starcke commented Apr 17, 2023

Removed indentation.

@starcke starcke requested a review from koesie10 April 18, 2023 07:48
@starcke starcke merged commit 4170e7f into main Apr 18, 2023
@starcke starcke deleted the starcke/update-java-lib branch April 18, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants