Skip to content

Show model filename in data extensions editor#2339

Merged
koesie10 merged 1 commit intomainfrom
koesie10/model-filename
Apr 18, 2023
Merged

Show model filename in data extensions editor#2339
koesie10 merged 1 commit intomainfrom
koesie10/model-filename

Conversation

@koesie10
Copy link
Copy Markdown
Member

This adds the model filename to the data extensions editor and will also allow the user to go to the model file by clicking on the filename.

This also updates the general UI to be somewhat more compact by moving the modeled percentages to be below the header in 1 line:

Screenshot 2023-04-17 at 16 20 50

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

This adds the model filename to the data extensions editor and will also
allow the user to go to the model file by clicking on the filename.

This also updates the general UI to be somewhat more compact by moving
the modeled percentages to be below the header in 1 line.
@koesie10 koesie10 requested a review from starcke April 17, 2023 14:21
@koesie10 koesie10 requested review from a team as code owners April 17, 2023 14:21
Copy link
Copy Markdown
Contributor

@starcke starcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and very useful

@koesie10 koesie10 merged commit a1ecb3d into main Apr 18, 2023
@koesie10 koesie10 deleted the koesie10/model-filename branch April 18, 2023 08:12
@elenatanasoiu
Copy link
Copy Markdown
Contributor

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants