Prompt non-codespace users for storage path#2341
Merged
elenatanasoiu merged 6 commits intomainfrom Apr 19, 2023
Merged
Conversation
elenatanasoiu
force-pushed
the
yer-an-input-box-query
branch
3 times, most recently
from
0f68ee9 to
56f7ac5
Compare
shati-patel
reviewed
Apr 17, 2023
Contributor
There was a problem hiding this comment.
Thanks, a couple of comments inline! 💖
We should probably add this setting to the package.json file, so we can add some documentation around it too. For example, see codeQL.variantAnalysis.controllerRepo 📂
Offer non-codespace users the option to configure their storage folder for skeleton packs. Suggested here: #2310 (comment) At the moment we're choosing to create our skeleton packs in the first folder in the workspace. This is fine for the codespace template because we can control the folder structure in that repo. For users outside of this we'd like to offer them the option to choose where to save their skeleton packs.
elenatanasoiu
force-pushed
the
yer-an-input-box-query
branch
from
7178923 to
db35cb2
Compare
shati-patel
reviewed
Apr 18, 2023
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Thanks! ✨
Should be good to go once the typo in the config name is fixed!
elenatanasoiu
force-pushed
the
yer-an-input-box-query
branch
from
928a070 to
312da9d
Compare
elenatanasoiu
force-pushed
the
yer-an-input-box-query
branch
from
312da9d to
5e76d0b
Compare
shati-patel
approved these changes
Apr 18, 2023
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Nice, looks good 🚢
(I've left a small observation inline, but I don't think it's hugely important. Mainly just leaving it here in case it's useful to know in future!)
Contributor
Author
|
Thanks @shati-patel ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Offer non-codespace users the option to configure their storage folder for skeleton packs.
Suggested here: #2310 (comment)
At the moment we're choosing to create our skeleton packs in the first folder in the workspace.
This is fine for the codespace template because we can control the folder structure in that repo.
For users outside of this we'd like to offer them the option to choose where to save their skeleton packs.