Move contextual and ast-viewer files into language-support#2368
Merged
norascheuch merged 7 commits intomainfrom Apr 26, 2023
Merged
Move contextual and ast-viewer files into language-support#2368norascheuch merged 7 commits intomainfrom
norascheuch merged 7 commits intomainfrom
Conversation
norascheuch
force-pushed
the
nora/move-files-misc1
branch
from
f5051fd to
d77e7b3
Compare
norascheuch
changed the title
charisk
reviewed
Apr 24, 2023
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
Generally looking good, just some minor comments/questions.
| @@ -1,3 +1,4 @@ | |||
| export * from "./contextual"; | |||
Contributor
There was a problem hiding this comment.
Did you mean to export everything from contextual to the outside world? I would have thought that some of it is only internal to language-support (e.g. the file-range-from-uri stuff).
Contributor
Author
There was a problem hiding this comment.
Discussed synchronously, fixed
…viewer/ast-builder
norascheuch
force-pushed
the
nora/move-files-misc1
branch
from
d77e7b3 to
38ee043
Compare
charisk
approved these changes
Apr 25, 2023
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
Looks good, just some potential improvements.
| import type { CommandManager } from "../packages/commands"; | ||
| import type { Uri, Range, TextDocumentShowOptions } from "vscode"; | ||
| import type { AstItem } from "../astViewer"; | ||
| import type { AstItem } from "../language-support/ast-viewer/ast-viewer"; |
Contributor
There was a problem hiding this comment.
Is this missing from index.ts?
norascheuch
force-pushed
the
nora/move-files-misc1
branch
from
38ee043 to
b6b3d3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of an endeavour to order files in the codebase according to the domain model. Here the folder
src/contextualis moved intolanguage-support.defaultto export. These defaults were removed and anindex.tsintroducedlanguage-support/contextual- andlanguage-support-ast-viewer-folderChecklist
ready-for-doc-reviewlabel there.