Simplify location URLs if start and end line are the same#2405
Simplify location URLs if start and end line are the same#2405aeisenberg merged 3 commits intogithub:mainfrom Marcono1234:simpler-location-url
Conversation
|
This looks great. Thank you for your contribution. One minor thing I would like to see is that with this change is that the test is no longer showing any multiline results (arguably this was a limitation of the test before, but there was only a single code path earlier). But, could you add at least one multiline result in one of the test files, like |
|
Failing test is likely a flake. |
I am not completely sure what you mean. If you had written "still shows multiline results", then I would have assumed you mean that something like So, what did you mean by "no longer showing any multiline results"? |
|
Apologies for that. You are correct. I missed those extra tests. Thanks for pointing them out. This PR looks great. |
When the start and end line of a result are the same, currently the extension creates location URLs which specify both line numbers, e.g.
...MyFile.js#L5-L5. This is appears to be redundant and can be simplified to just#L5.I am not very familiar with this project, so any feedback is appreciated!
Checklist
ready-for-doc-reviewlabel there.