Skip to content

Replace deprecated storagePath by storageUri#2408

Merged
koesie10 merged 4 commits intomainfrom
koesie10/replace-deprecated-storage-path
May 10, 2023
Merged

Replace deprecated storagePath by storageUri#2408
koesie10 merged 4 commits intomainfrom
koesie10/replace-deprecated-storage-path

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented May 8, 2023

This replaces access to the deprecated storagePath and globalStoragePath to use storageUri and globalStorageUri instead.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 added the secexp label May 8, 2023
@koesie10 koesie10 force-pushed the koesie10/replace-deprecated-storage-path branch 3 times, most recently from 4e2a540 to 8569b43 Compare May 9, 2023 08:11
koesie10 added 3 commits May 9, 2023 14:20
This replaces access to the deprecated `storagePath` and
`globalStoragePath` to use `storageUri` and `globalStorageUri` instead.
@koesie10 koesie10 marked this pull request as ready for review May 9, 2023 12:20
@koesie10 koesie10 requested review from a team as code owners May 9, 2023 12:20
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for tidying that up.

@koesie10 koesie10 force-pushed the koesie10/replace-deprecated-storage-path branch from b15b74c to 6e5188f Compare May 10, 2023 07:30
@koesie10 koesie10 enabled auto-merge May 10, 2023 07:31
@koesie10 koesie10 merged commit 7dfa6f0 into main May 10, 2023
@koesie10 koesie10 deleted the koesie10/replace-deprecated-storage-path branch May 10, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants