Skip to content

Split codeQL.goto and codeQL.previewQueryHelp command#2409

Merged
norascheuch merged 2 commits intomainfrom
nora/split-codeql-goto-commands
May 8, 2023
Merged

Split codeQL.goto and codeQL.previewQueryHelp command#2409
norascheuch merged 2 commits intomainfrom
nora/split-codeql-goto-commands

Conversation

@norascheuch
Copy link
Copy Markdown
Contributor

@norascheuch norascheuch commented May 8, 2023 •
edited
Loading

Splitting more commands to ensure clean telemetry.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@norascheuch norascheuch marked this pull request as ready for review May 8, 2023 12:41
@norascheuch norascheuch requested a review from a team as a code owner May 8, 2023 12:41
koesie10
koesie10 approved these changes May 8, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@norascheuch norascheuch merged commit a4f1f49 into main May 8, 2023
@norascheuch norascheuch deleted the nora/split-codeql-goto-commands branch May 8, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koesie10 koesie10 koesie10 approved these changes

Assignees

No one assigned

Labels

secexp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@norascheuch @koesie10