Skip to content

feat: Add more support kinds for data extensions #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GeekMasher wants to merge 1 commit into from
Closed

feat: Add more support kinds for data extensions #2415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion extensions/ql-vscode/src/data-extensions-editor/predicates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,16 @@ export const extensiblePredicateDefinitions: Record<
kind: row[7] as string,
},
}),
supportedKinds: ["sql", "xss", "logging"],
supportedKinds: [
"command-injection",
"html-injection",
"log-injection",
"response-splitting",
"path-injection",
"sql-injection",
"url-redirection",
"xpath-injection",
],
Comment on lines +85 to +94
Copy link
Copy Markdown
Contributor

@aeisenberg aeisenberg May 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the long term, we should be generating this list directly from the core libraries themselves. But this looks reasonable to me right now. I'll wait for the secexp team to approve this, since they are working on the feature.

Copy link
Copy Markdown
Author

@GeekMasher GeekMasher May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aeisenberg Makes complete sense and would be amazing to be done automatically.

},
summary: {
extensiblePredicate: "summaryModel",
Expand Down