Resolve queries instead of hardcoding the path#2416
Merged
Conversation
This will change the data extensions editor generator to resolve the queries based on the `modelgenerator` tag. This removes the requirement of having a `ql` folder in the workspace. I chose to use the path instead of the `id` for now to avoid having to resolve the query 4 times. This also avoids the need to map the language names to the language ID in the tag (i.e. `csharp` -> `cs`).
charisk
approved these changes
Jun 2, 2023
starcke
approved these changes
Jun 2, 2023
Contributor
starcke
left a comment
starcke
left a comment
There was a problem hiding this comment.
I think this is ok, and not worse than what we were doing before. Later we should establish some agreement with the maintainers of those queries.
| from: qlpack, | ||
| queries: ".", | ||
| include: { | ||
| "tags contain": "modelgenerator", |
Contributor
There was a problem hiding this comment.
I wonder how we should ensure that the tag of these are not changed (and that not too many other queries get into this tag). Good enough for now, but lets put a note in the missing functionality doc: https://docs.google.com/document/d/1OoCEtUcShiQG328sPIoS0wNR2pqIg4Umy79UEDiSqLk/edit#heading=h.9b4gwygshmfg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will change the data extensions editor generator to resolve the queries based on the
modelgeneratortag. This removes the requirement of having aqlfolder in the workspace.I chose to use the path instead of the
idfor now to avoid having to resolve the query 4 times. This also avoids the need to map the language names to the language ID in the tag (i.e.csharp->cs).Checklist
ready-for-doc-reviewlabel there.