Skip to content

Mark AppEventEmitter as disposable#2434

Merged
robertbrignull merged 2 commits intomainfrom
robertbrignull/disposable-event-emitter
May 22, 2023
Merged

Mark AppEventEmitter as disposable#2434
robertbrignull merged 2 commits intomainfrom
robertbrignull/disposable-event-emitter

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

Makes AppEventEmitter implement Disposable. This class is mirroring the VS Code EventEmitter class, and that does have a dispose method.

This means in places where we use app.createEventEmitter we can track the object and dispose of it, which helps mirror the places where we use EventEmitter directly and we already do this.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested review from a team as code owners May 22, 2023 11:32
@robertbrignull
Copy link
Copy Markdown
Contributor Author

Thanks for reviewing. I just realised I forgot to also make sure that DbManager is disposed of, so I've just pushed that. I think that change is small enough and in keeping with the rest of the PR so it doesn't invalidate the approval.

@robertbrignull robertbrignull enabled auto-merge May 22, 2023 12:36
@robertbrignull robertbrignull merged commit 73f359c into main May 22, 2023
@robertbrignull robertbrignull deleted the robertbrignull/disposable-event-emitter branch May 22, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants