Use app.createEventEmitter in QueryDiscovery#2437
Merged
robertbrignull merged 2 commits intomainfrom May 23, 2023
Merged
Conversation
koesie10
reviewed
May 23, 2023
| private readonly onDidChangeQueriesEmitter = this.push( | ||
| new EventEmitter<void>(), | ||
| ); | ||
| private readonly onDidChangeQueriesEmitter; |
Member
There was a problem hiding this comment.
Can we add a type here? I think this is now typed as any.
Contributor
Author
There was a problem hiding this comment.
Ah thanks for pointing this out. For me locally it was working out the correct type. Perhaps it's smart enough to see the single assignment in the constructor.
But I do kinda like things to be explicit and readable to the human eye, so putting a type here sounds good to me regardless.
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove a small dependency that
QueryDiscoveryhas on VS Code classes. I'm not sure if this one is strictly a blocker for making unit tests, but the method onAppis already there so it costs us nothing to use it.Checklist
ready-for-doc-reviewlabel there.