Skip to content

Don't create "." directory in queries/tests tree view#2442

Merged
shati-patel merged 1 commit intomainfrom
shati-patel/treeview-empty-dir
May 24, 2023
Merged

Don't create "." directory in queries/tests tree view#2442
shati-patel merged 1 commit intomainfrom
shati-patel/treeview-empty-dir

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

The createDirectory method that we use for populating the Queries Panel and Test Explorer tree view had a slight bug. If a query/test was directly under the root directory, we'd unnecessarily create an empty subdirectory called .
(instead of directly adding the query/test).

This PR prevents us from creating a directory when there's none to create. Thanks to @robertbrignull for the fix 🙇🏽‍♀️

(see internal linked issue for more details)

Checklist

N/A—feature-flagged for internal development only 🎏

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel shati-patel requested a review from a team as a code owner May 23, 2023 15:32
@shati-patel shati-patel merged commit 7ef35af into main May 24, 2023
@shati-patel shati-patel deleted the shati-patel/treeview-empty-dir branch May 24, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants