Don't create "." directory in queries/tests tree view#2442
Merged
shati-patel merged 1 commit intomainfrom May 24, 2023
Merged
Conversation
aeisenberg
approved these changes
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
createDirectorymethod that we use for populating the Queries Panel and Test Explorer tree view had a slight bug. If a query/test was directly under the root directory, we'd unnecessarily create an empty subdirectory called.(instead of directly adding the query/test).
This PR prevents us from creating a directory when there's none to create. Thanks to @robertbrignull for the fix 🙇🏽♀️
(see internal linked issue for more details)
Checklist
N/A—feature-flagged for internal development only 🎏
ready-for-doc-reviewlabel there.