Add tests of QueryTreeDataProvider#2444
Merged
robertbrignull merged 2 commits intomainfrom May 24, 2023
Merged
Conversation
shati-patel
approved these changes
May 24, 2023
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Thanks, tests looks good! 🧪
I don't fully understand the QueryDiscoverer class, but if it makes things easier then that's fine 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests of the
QueryTreeDataProviderclass.I investigated if we could make these unit tests rather than integration tests, but sadly it proved too complicated and not worth it for the benefit it gives.
To make this easier, I introduced a new
QueryDiscovererinterface which allows us to easily instantiateQueryTreeDataProviderin the tests without dealing with the more complicatedQueryDiscoveryclass and without Jest mocking. Do you think this interface is helpful and worth it? Suggestions on naming welcome?Checklist
ready-for-doc-reviewlabel there.