Split up local-databases.ts file into multiple files#2445
Merged
Conversation
charisk
approved these changes
May 24, 2023
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the clear commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
local-databases.tsfile is very large and hard to read. This PR moves all types into separate files so it's at least easier to find where each part is located. All moves are in separate commits so it's easier to keep track of which parts have moved. I've modified none of the functionality. I have removed 1 unused method which didn't fit in any of the new files.Checklist
ready-for-doc-reviewlabel there.