Skip to content

Add welcome text for the queries panel#2449

Merged
robertbrignull merged 1 commit intomainfrom
robertbrignull/queries-welcome
May 25, 2023
Merged

Add welcome text for the queries panel#2449
robertbrignull merged 1 commit intomainfrom
robertbrignull/queries-welcome

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

This gives some default text to display in the queries panel where there aren't any queries in the workspace. Suggestions welcome for what to put as the text, and we can always change the text later on.

Screenshot 2023-05-25 at 12 48 17

This shows whenever QueryTreeDataProvider returns no children for the root node, with no extra configuration needed. One complication is it also shows while the CodeQL extension is loading, so ideally the text shouldn't be confusing in this situation.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team May 25, 2023 11:52
@robertbrignull robertbrignull requested a review from a team as a code owner May 25, 2023 11:52
@robertbrignull
Copy link
Copy Markdown
Contributor Author

This might not be visible until #2447 is merged because that PR changes the behaviour to not include workspace folders which don't include any queries, as otherwise it'll always show an entry for the workspace folder, even if that directory has no children.

@robertbrignull robertbrignull merged commit 35a7eee into main May 25, 2023
@robertbrignull robertbrignull deleted the robertbrignull/queries-welcome branch May 25, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants