Add welcome text for the queries panel#2449
Merged
robertbrignull merged 1 commit intomainfrom May 25, 2023
Merged
Conversation
Contributor
Author
|
This might not be visible until #2447 is merged because that PR changes the behaviour to not include workspace folders which don't include any queries, as otherwise it'll always show an entry for the workspace folder, even if that directory has no children. |
charisk
approved these changes
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives some default text to display in the queries panel where there aren't any queries in the workspace. Suggestions welcome for what to put as the text, and we can always change the text later on.
This shows whenever
QueryTreeDataProviderreturns no children for the root node, with no extra configuration needed. One complication is it also shows while the CodeQL extension is loading, so ideally the text shouldn't be confusing in this situation.Checklist
ready-for-doc-reviewlabel there.