Skip to content

Avoid vscode reference from discovery.ts#2459

Merged
robertbrignull merged 2 commits intomainfrom
robertbrignull/discovery-logging
May 31, 2023
Merged

Avoid vscode reference from discovery.ts#2459
robertbrignull merged 2 commits intomainfrom
robertbrignull/discovery-logging

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

This should fix https://github.com/github/vscode-codeql/security/code-scanning/517

Instead of referencing extLogger directly, we can accept a logger in the constructor. It's a little clunky but I think it's the only way unless we want to remove that logging call.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team May 31, 2023 10:28
@robertbrignull robertbrignull requested a review from a team as a code owner May 31, 2023 10:28
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robertbrignull robertbrignull enabled auto-merge May 31, 2023 11:24
@robertbrignull robertbrignull changed the title Avoid vscode reference rfom discovery.ts Avoid vscode reference from discovery.ts May 31, 2023
@robertbrignull robertbrignull merged commit 0b6bcfd into main May 31, 2023
@robertbrignull robertbrignull deleted the robertbrignull/discovery-logging branch May 31, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants