Skip to content

Move selection-commands.ts to be in the vscode directory#2460

Merged
robertbrignull merged 1 commit intomainfrom
robertbrignull/selection-commond-vscode
May 31, 2023
Merged

Move selection-commands.ts to be in the vscode directory#2460
robertbrignull merged 1 commit intomainfrom
robertbrignull/selection-commond-vscode

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

Should fix https://github.com/github/vscode-codeql/security/code-scanning/521

The VS Code dependency we have is on showAndLogErrorMessage and I can't see a way to remove it without reducing functionality. But we can move it to the vscode directory and I don't think this is a huge problem compared to it being just in the common directory. The places where we'll want to use these methods from are going to already have VS Code dependencies.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested review from a team as code owners May 31, 2023 10:35
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@robertbrignull robertbrignull enabled auto-merge May 31, 2023 11:21
@robertbrignull robertbrignull merged commit 8badc1c into main May 31, 2023
@robertbrignull robertbrignull deleted the robertbrignull/selection-commond-vscode branch May 31, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants