Skip to content

Remove ignoreSourceArchive option from databases#2468

Merged
koesie10 merged 2 commits intomainfrom
koesie10/remove-ignore-source-archive-option
Jun 5, 2023
Merged

Remove ignoreSourceArchive option from databases#2468
koesie10 merged 2 commits intomainfrom
koesie10/remove-ignore-source-archive-option

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Jun 1, 2023

This option was used to ignore source archives for .testproj databases. It is only set to true or false when creating the database and could not be changed, so I don't think we need this option. It can simply be derived from the database URI. This simplifies handling of databases a bit.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10
Remove ignoreSourceArchive option from databases
0e47709 
This option was used to ignore source archives for `.testproj`
databases. It is only set to `true` or `false` when creating the
database and could not be changed, so I don't think we need this option.
It can simply be derived from the database URI. This simplifies handling
of databases a bit.
@koesie10 koesie10 added the secexp label Jun 1, 2023
@koesie10 koesie10 marked this pull request as ready for review June 1, 2023 13:56
@koesie10 koesie10 requested review from a team as code owners June 1, 2023 13:56
norascheuch
norascheuch approved these changes Jun 2, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@koesie10
Copy link
Copy Markdown
Member Author

koesie10 commented Jun 2, 2023

@aeisenberg Do you know if this is actually safe to do? The ignoreSourceArchive option is not being set in the extension itself, but could there be users who are changing this value manually in the workspace state?

@koesie10 koesie10 requested a review from aeisenberg June 2, 2023 10:01
aeisenberg
aeisenberg approved these changes Jun 2, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problem with this. It looks fine, but I haven't tried this out locally, though.

@koesie10 koesie10 merged commit 0d390aa into main Jun 5, 2023
@koesie10 koesie10 deleted the koesie10/remove-ignore-source-archive-option branch June 5, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

@norascheuch norascheuch norascheuch approved these changes

Assignees

No one assigned

Labels

secexp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@koesie10 @aeisenberg @norascheuch