Skip to content

Allow unclassified methods to be marked as neutral#2477

Merged
charisk merged 1 commit intomainfrom
charisk/unclassified-methods-as-neutral
Jun 2, 2023
Merged

Allow unclassified methods to be marked as neutral#2477
charisk merged 1 commit intomainfrom
charisk/unclassified-methods-as-neutral

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Jun 2, 2023

Ensure that even methods without classification are marked as neutral. See internal linked issue for details.

Checklist

N/A - internal only:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from koesie10 June 2, 2023 14:43
@charisk charisk requested a review from a team as a code owner June 2, 2023 14:43
koesie10
koesie10 approved these changes Jun 2, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@charisk charisk enabled auto-merge (squash) June 2, 2023 14:59
@charisk charisk merged commit c96fd81 into main Jun 2, 2023
@charisk charisk deleted the charisk/unclassified-methods-as-neutral branch June 2, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koesie10 koesie10 koesie10 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charisk @koesie10