Skip to content

Only allow scoped extension pack names#2479

Merged
koesie10 merged 1 commit intomainfrom
koesie10/validate-scoped-pack-name
Jun 6, 2023
Merged

Only allow scoped extension pack names#2479
koesie10 merged 1 commit intomainfrom
koesie10/validate-scoped-pack-name

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Jun 5, 2023

When packaging an extension pack, unscoped extension pack names are not allowed and calling codeql pack bundle will fail with an error. This command will be called when running a variant analysis, so these packs will not work for a variant analysis.

To improve the user experience, we now only allow scoped extension pack names. This means that the user will now have to enter a scope when creating a new extension pack.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

When packaging an extension pack, unscoped extension pack names are not
allowed and calling `codeql pack bundle` will fail with an error. This
command will be called when running a variant analysis, so these packs
will not work for a variant analysis.

To improve the user experience, we now only allow scoped extension pack
names. This means that the user will now have to enter a scope when
creating a new extension pack.
@koesie10 koesie10 added the secexp label Jun 5, 2023
@koesie10 koesie10 marked this pull request as ready for review June 5, 2023 11:37
@koesie10 koesie10 requested a review from a team as a code owner June 5, 2023 11:37
@koesie10 koesie10 enabled auto-merge June 6, 2023 07:50
@koesie10 koesie10 merged commit 10bd774 into main Jun 6, 2023
@koesie10 koesie10 deleted the koesie10/validate-scoped-pack-name branch June 6, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants