Skip to content

Add timeout to CLI tests#2489

Merged
koesie10 merged 1 commit intomainfrom
koesie10/add-cli-tests-timeout
Jun 8, 2023
Merged

Add timeout to CLI tests#2489
koesie10 merged 1 commit intomainfrom
koesie10/add-cli-tests-timeout

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Jun 7, 2023

It seems like some CLI tests are hanging and only completing after 6 hours when they run into the default timeout. This updates the timeout to 30 minutes. All CLI tests should complete in 30 minutes, so this should ensure that they are cancelled when they are stuck.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

It seems like some CLI tests are hanging and only completing after 6
hours when they run into the default timeout. This updates the timeout
to 30 minutes. All CLI tests should complete in 30 minutes, so this
should ensure that they are cancelled when they are stuck.
@koesie10 koesie10 added the secexp label Jun 7, 2023
@koesie10 koesie10 requested a review from a team June 7, 2023 13:42
@koesie10 koesie10 requested a review from a team as a code owner June 7, 2023 13:42
@koesie10 koesie10 merged commit a46a8d0 into main Jun 8, 2023
@koesie10 koesie10 deleted the koesie10/add-cli-tests-timeout branch June 8, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants