Skip to content

Split helpers.ts [Part 2]#2505

Merged
koesie10 merged 3 commits intomainfrom
koesie10/split-helpers-2
Jun 14, 2023
Merged

Split helpers.ts [Part 2]#2505
koesie10 merged 3 commits intomainfrom
koesie10/split-helpers-2

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Jun 12, 2023

This is the second part in a series that will split the helpers.ts file. Each commit splits one or more methods to a separate file or moves it to a more appropriate existing file. This makes them easier to test and decreases the number of things the helpers.ts file is doing.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review June 12, 2023 12:41
@koesie10 koesie10 requested review from a team as code owners June 12, 2023 12:41
Base automatically changed from koesie10/split-helpers to main June 12, 2023 12:42
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tidying this up! 🧹

@koesie10 koesie10 merged commit c6c5628 into main Jun 14, 2023
@koesie10 koesie10 deleted the koesie10/split-helpers-2 branch June 14, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants