Skip to content

Use containsPath where possible#2510

Merged
robertbrignull merged 1 commit intomainfrom
robertbrignull/use_contains_path
Jun 13, 2023
Merged

Use containsPath where possible#2510
robertbrignull merged 1 commit intomainfrom
robertbrignull/use_contains_path

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

Following on from #2509, these are two places that were doing their own check of if a path contains another path. We can use containsPath instead and it shouldn't change any behaviour, or it might make it more correct.

I haven't looked too hard into how this code is used, but only at the low level code. It should be equivalent, but I can run some tests if needed.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team as a code owner June 12, 2023 15:35
@robertbrignull robertbrignull enabled auto-merge June 13, 2023 09:05
@robertbrignull robertbrignull merged commit 019e377 into main Jun 13, 2023
@robertbrignull robertbrignull deleted the robertbrignull/use_contains_path branch June 13, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants