Skip to content

Add library to data extensions editor#2519

Merged
koesie10 merged 2 commits intomainfrom
koesie10/add-library-to-data-extensions-editor
Jun 19, 2023
Merged

Add library to data extensions editor#2519
koesie10 merged 2 commits intomainfrom
koesie10/add-library-to-data-extensions-editor

Conversation

@koesie10
Copy link
Copy Markdown
Member

This adds a new library column to the data extensions editor containing the JAR or DLL file the method is defined in. This will be used to group methods by library in the future. For now, it just shows in a column.

Screenshot 2023-06-16 at 12 02 23

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

This adds a new library column to the data extensions editor containing
the JAR or DLL file the method is defined in. This will be used to group
methods by library in the future. For now, it just shows in a column.
@koesie10 koesie10 requested a review from starcke June 16, 2023 10:56
@koesie10 koesie10 marked this pull request as ready for review June 16, 2023 10:56
@koesie10 koesie10 requested a review from a team as a code owner June 16, 2023 10:56
Copy link
Copy Markdown
Contributor

@starcke starcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just a question/comment.

Comment thread extensions/ql-vscode/src/data-extensions-editor/queries/java.ts Outdated
@koesie10 koesie10 enabled auto-merge June 19, 2023 09:30
@koesie10 koesie10 merged commit 5dcadd2 into main Jun 19, 2023
@koesie10 koesie10 deleted the koesie10/add-library-to-data-extensions-editor branch June 19, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants