Automatically create different model files per library#2521
Merged
Conversation
Base automatically changed from
koesie10/add-library-to-data-extensions-editor
to
main
June 19, 2023 10:07
Contributor
|
Before digging in I had a few thoughts/questions:
|
3 tasks
koesie10
force-pushed
the
koesie10/auto-create-model-files
branch
from
74a9481 to
a94f05d
Compare
This will remove the user input for a model file and will instead create 1 model file per library (JAR/DLL). The model filename will be based on the JAR/DLL name, but will remove the version number and the file extension. It will also normalize the name. These files will be created automatically, and the editor now also reads in all files contained in an extension pack to read the modeled methods. This could result in duplicates if the user has created a different file to contain the same modeled methods, but this is an edge-case that we're explicitly not handling.
koesie10
force-pushed
the
koesie10/auto-create-model-files
branch
from
a94f05d to
669f4a6
Compare
starcke
approved these changes
Jun 22, 2023
Contributor
starcke
left a comment
starcke
left a comment
There was a problem hiding this comment.
I think this looks good. It is of course a bit iffy with the version number, but this is definately good for version 1.
| return extensionPackOption.extensionPack; | ||
| } | ||
|
|
||
| async function pickModelFile( |
Contributor
There was a problem hiding this comment.
🎉 actually a nice simplification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will remove the user input for a model file and will instead create 1 model file per library (JAR/DLL). The model filename will be based on the JAR/DLL name, but will remove the version number and the file extension. It will also normalize the name.
These files will be created automatically, and the editor now also reads in all files contained in an extension pack to read the modeled methods. This could result in duplicates if the user has created a different file to contain the same modeled methods, but this is an edge-case that we're explicitly not handling.
Checklist
ready-for-doc-reviewlabel there.