Merged
Conversation
shati-patel
approved these changes
Jun 22, 2023
Contributor
There was a problem hiding this comment.
Good spot! 🪝
Out of interest, did the "Unwanted dependency on vscode API" CodeQL query catch these test files? Should it?
Contributor
Author
That wasn't how I noticed about the test files and I don't think we'd expect it to alert on any of the tests files. In the query we only look for files in the "src" directory. We could expand the query to include the tests, but it's a little less important, and the tests themselves will fail if you include a vscode dependency in the unit tests. I think it's fine as it is and we don't need to adjust the query. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When moving code out of the
/puredirectory and into/commonand other directories, I forgot about the tests. This PR moves all of the tests out of/pureand into other directories to match the files they are testing.Checklist
ready-for-doc-reviewlabel there.