Merged
Conversation
Similar to #2553, this changes the C# query to correctly report the name of nested types. I couldn't find a `nestedName` method for C#, so this adds one in the `AutomodelVsCode` library. C# seems to use `+` as a separator for nested types, as reported by `getQualifiedName()`: ``` GitHub.Nested.MyFirstClass+NestedClass ``` The `getApiName()` will now report: ``` GitHub.Nested#MyFirstClass+NestedClass.Test() ```
starcke
approved these changes
Jun 27, 2023
Contributor
starcke
left a comment
starcke
left a comment
There was a problem hiding this comment.
Makes sense to me, but probably good to check with the C# team.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #2553, this changes the C# query to correctly report the name of nested types. I couldn't find a
nestedNamemethod for C#, so this adds one in theAutomodelVsCodelibrary.C# seems to use
+as a separator for nested types, as reported bygetQualifiedName():The
getApiName()will now report:Checklist
ready-for-doc-reviewlabel there.