Skip to content

Add jump to definition in framework mode#2557

Merged
koesie10 merged 1 commit intomainfrom
koesie10/jump-to-def-framework-mode
Jun 28, 2023
Merged

Add jump to definition in framework mode#2557
koesie10 merged 1 commit intomainfrom
koesie10/jump-to-def-framework-mode

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Jun 27, 2023

This makes the method name and parameters in framework mode a link to the definition of the method. In framework mode, the usages contains 1 element, which is the location of the definition of the method. Therefore, we can simply use jumpToUsage to jump to the definition.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10
Add jump to definition in framework mode
5349a75 
This makes the method name and parameters in framework mode a link to
the definition of the method. In framework mode, the `usages` contains
1 element, which is the location of the definition of the method.
Therefore, we can simply use `jumpToUsage` to jump to the definition.
@koesie10 koesie10 marked this pull request as ready for review June 28, 2023 07:13
@koesie10 koesie10 requested a review from a team as a code owner June 28, 2023 07:13
@koesie10 koesie10 requested a review from starcke June 28, 2023 07:13
starcke
starcke approved these changes Jun 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@starcke starcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 as with the other link it is not easy to discover that the link is clickable, but hopefully asier's design will help with that.

@koesie10 koesie10 merged commit 6465786 into main Jun 28, 2023
@koesie10 koesie10 deleted the koesie10/jump-to-def-framework-mode branch June 28, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starcke starcke starcke approved these changes

Assignees

No one assigned

Labels

secexp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@koesie10 @starcke